Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installation description in README doesn't have a lot of small details #1123

Merged
merged 3 commits into from
Feb 3, 2023
Merged

Installation description in README doesn't have a lot of small details #1123

merged 3 commits into from
Feb 3, 2023

Conversation

krllstdn
Copy link
Contributor

@krllstdn krllstdn commented Jan 4, 2023

Closes #1092

@krllstdn krllstdn marked this pull request as ready for review January 4, 2023 19:18
@krllstdn krllstdn force-pushed the 1092_installation_description_in_readme_doesn't_have_a_ branch from a26760a to 3acb786 Compare January 4, 2023 19:21
abragtim
abragtim requested changes Jan 6, 2023
View reviewed changes
Copy link
Collaborator

@abragtim abragtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Několik drobných úprav a zadal jsem několik otázek. Ovšem nemůžu ale ověřit technickou část README specifickou pro ubuntu.
Taky v plánu issue je napsáno "swagger (openapi-generator) needs java 8 to work", ale podle issue #1091 asi chápu, že Java 8 už není potřeba, správně?

txmatching/web/frontend/README.md Outdated Show resolved Hide resolved
txmatching/web/frontend/README.md Outdated Show resolved Hide resolved
txmatching/web/frontend/README.md Outdated Show resolved Hide resolved
txmatching/web/frontend/README.md Outdated Show resolved Hide resolved
@krllstdn
Copy link
Contributor Author

@abragtim jo. nejak openapi-generator se nechtel spoustet bez java 8 a potom jsem ho preinstaloval a uz nejak to slo s modernejsimi verzemi. Jak to mas ty, jakou verzi javy mas nainstalovano? a mozna sis mel podobny problem?

@abragtim
Copy link
Collaborator

abragtim commented Jan 11, 2023 •
edited
Loading

@abragtim jo. nejak openapi-generator se nechtel spoustet bez java 8 a potom jsem ho preinstaloval a uz nejak to slo s modernejsimi verzemi. Jak to mas ty, jakou verzi javy mas nainstalovano? a mozna sis mel podobny problem?

@krllstdn
Podíval jsem se, že právě mám nainstalovanou Javu 8

@krllstdn
Copy link
Contributor Author

@abragtim hmmmm, no oni tam v readme psali, ze pro MacOS fakt je potreba v jave 8, ale jak to je v linuxu?..

@kristinagalik jakou verzi javy mas nainstalovanou?

kristinagalik
kristinagalik reviewed Jan 11, 2023
View reviewed changes
Copy link
Contributor

@kristinagalik kristinagalik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jakou verzi javy mas nainstalovanou?
image

txmatching/web/frontend/README.md Outdated Show resolved Hide resolved
@abragtim
Copy link
Collaborator

abragtim commented Jan 11, 2023 •
edited
Loading

@abragtim hmmmm, no oni tam v readme psali, ze pro MacOS fakt je potreba v jave 8, ale jak to je v linuxu?..

@kristinagalik jakou verzi javy mas nainstalovanou?

Tak zítra zkusím to spustit u sebe na jiné verzi Java a dám vědět. Jestli opravdu musím mít Javu 8, tak by bylo dobré to propsat v README.

@krllstdn
Copy link
Contributor Author

@abragtim dik, tady je odkaz na jejich readme https://github.com/OpenAPITools/openapi-generator#1---installation zkus jeste prosim zbuildit ten jar

@abragtim
Copy link
Collaborator

@krllstdn , podle mě Java 8 není třeba ani na mac. Zkusil jsem rozběhnout celý txm, generate-swagger-all, testy a nainstalovat ten .jar. Tady je výstup terminalu a asi problémy nejsou.
Uložený výstup terminálu_jar.txt
Uložený výstup terminálu.txt

@krllstdn krllstdn force-pushed the 1092_installation_description_in_readme_doesn't_have_a_ branch from 432ea56 to a83fb43 Compare January 30, 2023 19:35
@krllstdn krllstdn requested review from abragtim and removed request for abragtim January 30, 2023 19:36
kubantjan
kubantjan previously approved these changes Feb 2, 2023
View reviewed changes
abragtim
abragtim previously approved these changes Feb 3, 2023
View reviewed changes
Copy link
Collaborator

@abragtim abragtim left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opravdu na mac s ARM condou nelze spustit. Padá to kvůli binarkům CBC (mip), které jsou jen pro Intel

@krllstdn krllstdn force-pushed the 1092_installation_description_in_readme_doesn't_have_a_ branch from a83fb43 to 19e443a Compare February 3, 2023 10:31
@kubantjan kubantjan dismissed stale reviews from abragtim and themself via 19e443a February 3, 2023 10:39
@krllstdn krllstdn force-pushed the 1092_installation_description_in_readme_doesn't_have_a_ branch from 19e443a to 738b491 Compare February 3, 2023 10:41
@krllstdn krllstdn merged commit 2020c19 into master Feb 3, 2023
@krllstdn krllstdn deleted the 1092_installation_description_in_readme_doesn't_have_a_ branch February 3, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristinagalik kristinagalik kristinagalik left review comments

@kubantjan kubantjan kubantjan approved these changes

@abragtim abragtim abragtim left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Installation description in README doesn't have a lot of small details
4 participants
@krllstdn @abragtim @kubantjan @kristinagalik