Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make optimiser module consistent with the Hungarian one #1081

Merged
merged 8 commits into from
Jan 24, 2023
Merged

Make optimiser module consistent with the Hungarian one #1081

merged 8 commits into from
Jan 24, 2023

Conversation

krllstdn
Copy link
Contributor

No description provided.

@krllstdn krllstdn self-assigned this Nov 21, 2022
@krllstdn
Copy link
Contributor Author

I've pushed only to run tests. The PR is still a work in progress.

@krllstdn krllstdn linked an issue Nov 22, 2022 that may be closed by this pull request
Make optimizer module schema consistent with the hungarian one #998
Closed
@krllstdn
Copy link
Contributor Author

@kubantjan nemuzu lokalne vygenerovat ten swagger, muzes prosim ho vygenerovat?

@kubantjan
Copy link
Member

swagger jsem zkusil pregenerovat, ale je identicky s aktualnim a dle erorrou co vidim tak ty vubec nesouvisi se swaggerem.

@kubantjan
Copy link
Member

@krllstdn issues jdou podle me za tebou ne za swaggerem.

kubantjan
kubantjan requested changes Nov 29, 2022
View reviewed changes
Copy link
Member

@kubantjan kubantjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

viz komenty

@krllstdn krllstdn force-pushed the make-optimizer-module-consistent-with-hungarian-one branch 3 times, most recently from 2a32329 to 0674b4f Compare December 5, 2022 20:44
@kristinagalik kristinagalik self-requested a review December 6, 2022 08:14
@krllstdn krllstdn force-pushed the make-optimizer-module-consistent-with-hungarian-one branch from 0674b4f to 0541c9f Compare December 6, 2022 15:24
kristinagalik
kristinagalik suggested changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@kristinagalik kristinagalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

len par drobnosti :)

txmatching/data_transfer_objects/optimizer/optimizer_in_swagger.py Outdated Show resolved Hide resolved
txmatching/optimizer/optimizer_functions.py Outdated Show resolved Hide resolved
txmatching/scorers/compatibility_graph.py Outdated Show resolved Hide resolved
txmatching/scorers/compatibility_graph.py Outdated Show resolved Hide resolved
@krllstdn krllstdn force-pushed the make-optimizer-module-consistent-with-hungarian-one branch from 08f76d4 to cd27b29 Compare December 7, 2022 22:47
@krllstdn krllstdn mentioned this pull request Dec 8, 2022
Open
kristinagalik
kristinagalik previously approved these changes Dec 13, 2022
View reviewed changes
@krllstdn krllstdn force-pushed the make-optimizer-module-consistent-with-hungarian-one branch from d59d353 to 085ab6d Compare December 13, 2022 15:50
kubantjan
kubantjan requested changes Dec 14, 2022
View reviewed changes
Copy link
Member

@kubantjan kubantjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

potrebuju vyjasnit to issue zadani

kubantjan
kubantjan requested changes Dec 15, 2022
View reviewed changes
Copy link
Member

@kubantjan kubantjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prvni komentare

tests/database/services/test_file_upload.py Outdated Show resolved Hide resolved
kubantjan
kubantjan requested changes Dec 16, 2022
View reviewed changes
tests/web/test_optimizer_api.py Outdated Show resolved Hide resolved
@krllstdn krllstdn force-pushed the make-optimizer-module-consistent-with-hungarian-one branch 2 times, most recently from a3823fc to 8d31e22 Compare January 2, 2023 14:27
kristinagalik
kristinagalik reviewed Jan 3, 2023
View reviewed changes
Copy link
Contributor

@kristinagalik kristinagalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

len jedna otazka, inak imo ok :)

nebolo by mat dobre niekde nejaku premennu na styl HLA_SCORE = 'hla_compatibility_score' aby sa potom kod lahsie v buducnosti upravoval? ale je to len myslienka, ak myslis ze takto to je ok tak fajn

@krllstdn krllstdn force-pushed the make-optimizer-module-consistent-with-hungarian-one branch from d5afc72 to d2ffb72 Compare January 4, 2023 09:51
@krllstdn
Copy link
Contributor Author

krllstdn commented Jan 4, 2023

@kristinagalik good point. Pridal jsem tam tu konstantu

@krllstdn krllstdn force-pushed the make-optimizer-module-consistent-with-hungarian-one branch from d2ffb72 to ca68dfa Compare January 4, 2023 10:00
kristinagalik
kristinagalik previously approved these changes Jan 4, 2023
View reviewed changes
@kubantjan kubantjan force-pushed the make-optimizer-module-consistent-with-hungarian-one branch from ca68dfa to d016c3f Compare January 5, 2023 07:50
kubantjan
kubantjan requested changes Jan 11, 2023
View reviewed changes
Copy link
Member

@kubantjan kubantjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jak je to s migraci? Nerozbije se nahodou migrace? Ze historicky ukladame ten compatibility graf jinak, nebo je tohle poreseny?

na to by bylo jeste fajn mrknout. pokud jsi to neresil a vyzkouset to pak.

Tzn vytvorit txm z mastra, nahrat tam nejaky paicenta aby to proste fungovalo (staci to non empty db) a pak checkout nove verze a jeji spusteni a kontrola ze vse beha.

@krllstdn
Copy link
Contributor Author

@kubantjan vyzkousel jsem, beha na obou solverech na databazi s mastru bez problemu

@kubantjan
Copy link
Member

no ok, a jak to teda ted funguje? Uklada se do databaze furt stejny objekt nebo jiny? @krllstdn

@krllstdn
Copy link
Contributor Author

@kubantjan Uklada se ten samy object (dict: list of ints).
Chces ten seznam zmenit na dict, kde bude primo napsano ze, to treti cislo je 'hla_compatibility_score', nebo je to takhle v pohode?

kubantjan
kubantjan requested changes Jan 16, 2023
View reviewed changes
Copy link
Member

@kubantjan kubantjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, tak to nechcme v db tak jak to je, ale jeste jsem ti dal nejaky komentar

txmatching/database/services/scorer_service.py Outdated Show resolved Hide resolved
txmatching/database/services/scorer_service.py Outdated Show resolved Hide resolved
@krllstdn krllstdn force-pushed the make-optimizer-module-consistent-with-hungarian-one branch from d016c3f to 612c412 Compare January 21, 2023 15:31
@krllstdn krllstdn requested review from kubantjan and kristinagalik and removed request for kristinagalik January 21, 2023 15:43
@krllstdn krllstdn merged commit 817aa71 into master Jan 24, 2023
@krllstdn krllstdn deleted the make-optimizer-module-consistent-with-hungarian-one branch January 24, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kubantjan kubantjan kubantjan approved these changes

@kristinagalik kristinagalik kristinagalik left review comments

Assignees

@krllstdn krllstdn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make optimizer module schema consistent with the hungarian one
3 participants
@krllstdn @kubantjan @kristinagalik