Skip to content

Sequence: add max padding attribute#48

Merged
cchampet merged 11 commits intomikrosimage:developfrom
cchampet:dev_addMaxPaddingToSequence
Jan 15, 2016
Merged

Sequence: add max padding attribute#48
cchampet merged 11 commits intomikrosimage:developfrom
cchampet:dev_addMaxPaddingToSequence

Conversation

@cchampet
Copy link
Collaborator

  • Attribute _fixedPadding: if 0, variable padding.
  • Attribute _maxPadding: Number max of padding used to enumerate the sequence.
    For fixed sequences, it is equal to the padding.
    Useful for sequence with a variable or an unknown padding (unknown = when no frame begins with a '0' padding character).

Clement Champetier added 5 commits January 14, 2016 14:34
* max padding: Number max of padding used to enumerate the sequence.
* So in case of sequence with a variable or an unknown padding, we keep
the max padding information in this attribute.
To return the sequence as a string with a pattern using printf style.
The path will use a printf style instead of the "standard"
sequenceParser pattern.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an example for the ambiguous case.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we remove this test, we lose information.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so because _strictPadding == 0 is the same as _strictPadding == false.

@cchampet cchampet force-pushed the dev_addMaxPaddingToSequence branch from 5eae420 to e9789f7 Compare January 15, 2016 13:14
@cchampet cchampet force-pushed the dev_addMaxPaddingToSequence branch from e9789f7 to 9c367d6 Compare January 15, 2016 13:21
cchampet added a commit that referenced this pull request Jan 15, 2016
@cchampet cchampet merged commit a073be8 into mikrosimage:develop Jan 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants