New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnitTests: Fix compilation error on MSVC. Update doctest to v2.4.11. #491

Merged

mikke89 merged 1 commit into mikke89:master from mwl4:tests_compile_error_msvc

Jul 27, 2023

Contributor

mwl4 commented Jul 27, 2023

UnitTests fails to compile on MSVC without doctest update. Log:

Tests\Source\UnitTests\Math.cpp(44,2): error C3861: 'DOCTEST_REQUIRE': identifier not found
Tests\Source\Benchmarks\DataBinding.cpp(165,2): error C3861: 'DOCTEST_REQUIRE': identifier not found
.....


          Update doctest to v2.4.11.

5785d7f

UnitTests fails to compile on msvc without update.

mikke89 added the build label

mikke89 merged commit 4504817 into mikke89:master

13 checks passed

Owner

mikke89 commented Jul 27, 2023

Thanks for the pull request. I haven't seen this issue myself, but updating the library is good to me regardless.

mwl4 deleted the tests_compile_error_msvc branch

August 22, 2023 23:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build