Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a function that enables all the variables in a data model to be m… #289

Merged
merged 2 commits into from
Mar 6, 2022
Merged

Add a function that enables all the variables in a data model to be m… #289

merged 2 commits into from
Mar 6, 2022

Conversation

EhWhoAmI
Copy link

@EhWhoAmI EhWhoAmI commented Mar 5, 2022 •
edited
Loading

This is a helper function that fills up what I feel is a hole in the datamodel API.

mikke89
mikke89 reviewed Mar 5, 2022
View reviewed changes
Copy link
Owner

@mikke89 mikke89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I can see this being useful!

I have a couple of suggestions, I'll merge this as soon as they are addressed :)

Include/RmlUi/Core/DataModelHandle.h Outdated Show resolved Hide resolved
Source/Core/DataModel.cpp Outdated Show resolved Hide resolved
@mikke89 mikke89 added data binding enhancement New feature or request labels Mar 5, 2022
@EhWhoAmI EhWhoAmI requested a review from mikke89 March 6, 2022 01:16
@mikke89 mikke89 merged commit 48aacad into mikke89:master Mar 6, 2022
@mikke89
Copy link
Owner

mikke89 commented Mar 6, 2022

Perfect, thank you!

This was referenced Mar 10, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikke89 mikke89 Awaiting requested review from mikke89

Assignees
No one assigned
Labels
data binding enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EhWhoAmI @mikke89