-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore curly brackets inside string literals in data expressions #190
Conversation
I'm currently integrating sprintf as a function for data expressions (in combination with my i18n strings) based on the fmt lib. |
Thanks! I think it makes more sense to move Your translation stuff sounds cool, I'd love to see more of it. We wouldn't want fmt as a core dependency, could it be integrated into the databinding sample perhaps? |
The issue definitely is the variant type and non-variadic printf-usage. That's why i had to use the fmt library. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Looks good to me, only there is an issue with the XMLParseTools.cpp
diff, is it the line endings again?
yeah thanks, i dont know why. i have autocrlf off... |
I think that should be on if you're on Windows? |
oh does it? okay |
Data expressions like {{ 'test {} with format library' }} currently dont work with libraries like fmt, because curly braces inside the string trigger an error. This PR fixes this.