Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twitpic.com support #579

Closed
panhartstuff opened this issue Jan 14, 2020 · 1 comment
Closed

twitpic.com support #579

panhartstuff opened this issue Jan 14, 2020 · 1 comment

Comments

@panhartstuff
Copy link

Older twitter accounts used to use an older image hosting site called twitpic.com
Can we add support for that to the Twitter extractor?

An interesting note is that they used to allow only one direct image embed per tweet. So if you want to post multiple images, you need to type in the direct links into the tweet, but only one of the links would be embedded.
Example:
https://twitter.com/i/web/status/112900228289540096
So other than checking the embed, we need to also check the contents of the tweet for twitpic.com links.

Some more examples:
https://twitter.com/i/web/status/110315630179258368
https://twitter.com/i/web/status/112900881254588417
https://twitter.com/i/web/status/117927358534647808
https://twitter.com/i/web/status/143356792175468545

You also could embed the twitpic image directly without putting the twitpic link into your tweet's content. Not sure how they work:
https://twitter.com/i/web/status/100501770131865600
https://twitter.com/i/web/status/100504406205792256
https://twitter.com/i/web/status/103528968719826944
https://twitter.com/i/web/status/112839221999448064

@mikf
Copy link
Owner

mikf commented Jan 18, 2020

Support for TwitPic embeds is done (25d5ec4) and can be enabled with the twitter.twitpic option.
I just have some general questions about it, because I suspect this can be improved:

  • Is it possible to have a TwitPic image and "regular" Twitter images/videos in the same Tweet? The code is currently assuming that that's case, but could be simplified otherwise
  • Do you know a way to improve image quality/resolution by manipulating their URLs (*)? They have a /large/ segment in them, but the few things I've tried here only resulted in an error.
  • I've read that TwitPic has/had an API. Do you know if that's still available or is the only way to get a TwitPic image to visit its HTML website?

(*)

https://dn3pm25xmtlyu.cloudfront.net/photos/large/395427758.jpg?Expires=1580228096&Signature=FrYb2rEMFkj8WbueoTJwNKZ-lhfH0lT~xQcdabxYTh9vgCkPLgryhuI0gm3mApGOXyXqwHXw22YJPYarWBoR36Tdb-NEyEie84OJyUwsPeEaKoJTTWcz~9rP9iQ3-cJbSowyHVrh7Zn~f8XtbSIxvl-UXu0AP-ynbaiVt8qb-eutJBOrq0zbP0X6jaySEMcWrfWzUk3lYQLaifuhNyaj0KfSz12jIHfXSj18B~hmg-iDRFioKaTvtPkpJZkTAgBfeRjMjQsOwIUbS5KdC3RZ2MT1D41UR6Om0bWJOIT5tvTcFybPxRY89Iyvk6SViJdnB11tRWBxasyGVqIQhsNLFA__&Key-Pair-Id=APKAJROXZ7FN26MABHYA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants