Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Imgur Problem #380

Closed
wankio opened this issue Aug 12, 2019 · 2 comments
Closed

Imgur Problem #380

wankio opened this issue Aug 12, 2019 · 2 comments
Labels
bug

Comments

@wankio
Copy link
Contributor

wankio commented Aug 12, 2019 •
edited
Loading

Some url is not working

does not exists
imgur.com/gallery/mxvfvzp
imgur.com/gallery/zf2fIms
imgur.com/gallery/Mg6wWzM

Unable to download data
imgur.com/gallery/XCGwNs5 (it have hidden \n\n in title, really strange

and some i'm not remember url with another error
@mikf
Copy link
Owner

mikf commented Aug 12, 2019

All imgur gallery URLs get internally rewritten to https://imgur.com/a/<ID>/all and that doesn't work for your URLs. (for example imgur.com/gallery/mxvfvzp becomes https://imgur.com/a/mxvfvzp/all which yields a 404: Not Found)

As for imgur.com/gallery/XCGwNs5: It downloads for me, but Windows doesn't seem to like \n in its filenames (and probably some other special characters as well)

@mikf mikf added the bug label Aug 12, 2019
mikf added a commit that referenced this issue Aug 14, 2019
@mikf
[imgur] distinguish album and gallery URLs (#380)
829b1cc 
A gallery can be either an album or a single image.
@mikf
Copy link
Owner

mikf commented Aug 14, 2019

/gallery/ URLs from Imgur can apparently be either an album or a single image. The necessary checks have been added in 829b1cc and your first three URLs are now going to work.

Any whitespace (like \n) now also gets stripped from album titles and imgur.com/gallery/XCGwNs5 should therefore successfully download on a Windows machine, but it is probably a better idea to universally remove any control characters from all filesystem paths

mikf added a commit that referenced this issue Aug 17, 2019
@mikf
Remove control characters from filesystem paths
5a21099 
- add 'path-remove' option to specify the set of characters that
 should be removed
- rename 'restrict-filenames' to 'path-restrict'
- #348, #380
@mikf mikf closed this as completed Aug 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikf @wankio