Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support for ripping discord rips on kemono.party (feature request) #1940

Closed
left1000 opened this issue Oct 10, 2021 · 10 comments
Closed

No support for ripping discord rips on kemono.party (feature request) #1940

left1000 opened this issue Oct 10, 2021 · 10 comments

Comments

@left1000
Copy link

left1000 commented Oct 10, 2021

There is no support for ripping discord rips on kemono.party, the discord rips on kemono have a weird layout, so maybe this isn't possible?

Just go here https://kemono.party/artists and on the drop down menu for service pick discord.

The weird way all the images fit on one screen with an endless load more button might be what makes it hard? I dunno.

edit: I don't know how to label this a request, sorry.

@God-damnit-all
Copy link
Contributor

@mikf Could you add the channel names into the metadata?

@mikf
Copy link
Owner

mikf commented Oct 16, 2021

@ImportTaste 003f259
This also fixes a bug where it would only download from the first channel on a server.

And 70005e3 allows to select which channel to download from by adding #<channel name> to the URL.

@God-damnit-all
Copy link
Contributor

@ImportTaste 003f259 This also fixes a bug where it would only download from the first channel on a server.

And 70005e3 allows to select which channel to download from by adding #<channel name> to the URL.

Slight issue with the implementation. Since channels can have their content updated in any order, the extractor should treat them similarly to subcategories when it comes to the skip option.

In other words, currently, when using a skip option like "abort:1", the extractor stops completely when it hits a filename collision, but the desired behavior would be for it to start checking the next channel.

@God-damnit-all
Copy link
Contributor

@mikf I came across another issue. Some artists just post a cdn.discordapp.com / media.discordapp.net URL in chat, which doesn't embed on the kemono.party website, so gallery-dl isn't currently downloading them.

mikf added a commit that referenced this issue Oct 18, 2021
@mikf
Copy link
Owner

mikf commented Oct 18, 2021

Slight issue with the implementation. Since channels can have their content updated in any order, the extractor should treat them similarly to subcategories when it comes to the skip option.

In other words, currently, when using a skip option like "abort:1", the extractor stops completely when it hits a filename collision, but the desired behavior would be for it to start checking the next channel.

fixed in bcbf9bc

Some artists just post a cdn.discordapp.com / media.discordapp.net URL in chat, which doesn't embed on the kemono.party website, so gallery-dl isn't currently downloading them.

Which server? I'd like to see an example of that but haven't managed to find one myself.

@God-damnit-all
Copy link
Contributor

God-damnit-all commented Oct 18, 2021

Slight issue with the implementation. Since channels can have their content updated in any order, the extractor should treat them similarly to subcategories when it comes to the skip option.
In other words, currently, when using a skip option like "abort:1", the extractor stops completely when it hits a filename collision, but the desired behavior would be for it to start checking the next channel.

fixed in bcbf9bc

Some artists just post a cdn.discordapp.com / media.discordapp.net URL in chat, which doesn't embed on the kemono.party website, so gallery-dl isn't currently downloading them.

Which server? I'd like to see an example of that but haven't managed to find one myself.

I posted it here:
https://snippet.host/udbq

@mikf
Copy link
Owner

mikf commented Oct 23, 2021

@ImportTaste
b6443c5 adds "inline" image support.

@God-damnit-all
Copy link
Contributor

Ran into a small issue. Aside from what I mentioned here b6443c5#r58549311, sometimes URLs are surrounded with angle brackets <https://blahblahblah> to keep them from embedding in chat. It seems the extractor is extracting it with the > bracket in the URL.

@God-damnit-all
Copy link
Contributor

Apparently media.discordapp.net is used for thumbnails and can be replaced with cdn.discordapp.com to retrieve the full size image.

mikf added a commit that referenced this issue Oct 24, 2021
- extract media.discordapp.*NET* URLs
- rewrite media.discordapp.net to cdn.discordapp.com
- use a more restricted set of characters for the URL path
@mikf
Copy link
Owner

mikf commented Oct 24, 2021

@ImportTaste fixed in f1487a3.
It now detects links to media.discordapp.net and rewrites them to cdn.discordapp.com. Angle brackets and other non-URL characters are now properly excluded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants