Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Compare abort/terminate/exit settings #1592

Closed
God-damnit-all opened this issue Jun 1, 2021 · 4 comments
Closed

[Feature Request] Compare abort/terminate/exit settings #1592

God-damnit-all opened this issue Jun 1, 2021 · 4 comments
Labels
feature-request

Comments

@God-damnit-all
Copy link
Contributor 

compare.finish
----------------
Type
    ``string``
Default
    ``null``
Description
    Controls whether to halt extraction when files compare as equal.

    * ``"abort"``: Stop the current extractor run
    * ``"abort:N"``: Stop the current extractor run after ``N`` consecutive matches

    * ``"terminate"``: Stop the current extractor run, including parent extractors
    * ``"terminate:N"``: Stop the current extractor run, including parent
      extractors, after ``N`` consecutive matches

    * ``"exit"``: Exit the program altogether
    * ``"exit:N"``: Exit the program after ``N`` consecutive matches
God-damnit-all referenced this issue Jun 22, 2021
@mikf
[kemonoparty] update default filenames and archive IDs (#1514)
e9ab973 
Add an enumeration index so that attachments and regular files with the
same filename still get downloaded and not counted as duplicate files
(even though for patreon posts they usually are)

This invalidates all previously generated archive IDs.
To keep using old names and IDs, set
'filename' to "{id}_{title}_{filename}.{extension}" and
'archive-format' to "{service}_{user}_{id}_{filename}.{extension}".
@God-damnit-all
Copy link
Contributor Author

God-damnit-all commented Sep 27, 2021 •
edited
Loading

@mikf Since you just added FUNDING.yml, I'd be willing to put $5 in the tip jar to make this a priority. I've been holding off on scraping kemono.party waiting for this feature.

The idea is I want to set the filenames back to {id}_{title}_{filename}.{extension} and I'd use compare with enumerate. This works great for the initial run, but consecutive runs have no way of stopping automatically without redownloading everything.

mikf added a commit that referenced this issue Oct 1, 2021
@mikf
[postprocessor:compare] extend 'action' option (#1592)
cdd72e1 
allow setting it to "abort", "terminate", or "exit" as with 'skip'
@God-damnit-all
Copy link
Contributor Author

God-damnit-all commented Oct 1, 2021 •
edited
Loading

@mikf I noticed you added this suggestion to the action setting instead, but based it off replace. As I mentioned above though, I needed it for enumerate.

I sent the tip as promised, but unfortunately I still can't do what I was hoping to.

@God-damnit-all God-damnit-all reopened this Oct 1, 2021
@God-damnit-all God-damnit-all mentioned this issue Oct 1, 2021
Closed
mikf added a commit that referenced this issue Oct 5, 2021
@mikf
[postprocessor:compare] add 'equal' option (#1592)
df8050b 
Move functionality from cdd72e1 to its own option,
where it can be used with any 'action'
@mikf
Copy link
Owner

mikf commented Oct 5, 2021

@ImportTaste df8050b moves abort/terminate/exit to their own separate equal option (it triggers when files compare as equal). Hopefully that's more useful than cdd72e1.

@God-damnit-all
Copy link
Contributor Author

Yes, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[postprocessor:compare] move stopping actions to new break setting
2 participants
@mikf @God-damnit-all