Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SmugMug special case #100

Closed
shiek opened this issue Aug 31, 2018 · 4 comments
Closed

SmugMug special case #100

shiek opened this issue Aug 31, 2018 · 4 comments

Comments

@shiek
Copy link

shiek commented Aug 31, 2018

Hi,
Thanks so much for this amazing tool :D

Could you add support for this type of smugmug link please?
https://www.smugmug.com/gallery/n-GLCjnD
I just get this error:
[gallery-dl][error] No suitable extractor found for 'https://www.smugmug.com/gallery/n-GLCjnD'

Thanks

@Hrxn
Copy link
Contributor

Hrxn commented Aug 31, 2018

Could you try it with this?
gallery-dl 'smugmug:album:n-GLCjnD'

@shiek
Copy link
Author

shiek commented Sep 1, 2018

[smugmug][error] The resource (gallery/image/user) at 'smugmug:album:n-GLCjnD' does not exist

It also doesn't work like this:

gallery-dl --verbose smugmug:album:6VRT8G

[gallery-dl][debug] Version 1.5.2
[gallery-dl][debug] Python 3.5.4 - Windows-10-10.0.17134-SP0
[gallery-dl][debug] requests 2.18.4 - urllib3 1.22
[gallery-dl][debug] Starting DownloadJob for 'smugmug:album:6VRT8G'
[smugmug][debug] Using api_key authentication
[smugmug][debug] Using SmugmugAlbumExtractor for 'smugmug:album:6VRT8G'
[urllib3.connectionpool][debug] Starting new HTTPS connection (1): api.smugmug.com
[urllib3.connectionpool][debug] https://api.smugmug.com:443 "GET /api/v2/album/6VRT8G?_expand=User&_verbosity=1&APIKey=DFqxg4jf7GrtsQ5PnbNB8899zKfnDrdK HTTP/1.1" 200 556
[smugmug][error] An unexpected error occurred: KeyError - 'User'. Please run gallery-dl again with the --verbose flag, copy its output and report this issue on https://github.com/mikf/gallery-dl/issues .
[smugmug][debug] Traceback
Traceback (most recent call last):
  File "\gallery_dl\job.py", line 64, in run
    for msg in self.extractor:
  File "\gallery_dl\extractor\smugmug.py", line 61, in items
    user = album["Uris"]["User"]
KeyError: 'User'

@mikf
Copy link
Owner

mikf commented Sep 1, 2018

Your Smugmug link and any other album without an explicit owner should work now.

smugmug:album:GLCjnD wouldn't have worked in this case, even if gallery-dl would have been able to deal with owner-less albums. It requires an album ID, but n-GLCjnD is a node ID and resolves to the album 6VRT8G. Smugmug's internal structure is a bit convoluted, but quite powerful from a developer's point of view.

@shiek
Copy link
Author

shiek commented Sep 1, 2018

Works flawless - thanks for the super quick fix! :D

@shiek shiek closed this as completed Sep 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants