forked from TextureGroup/Texture
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Add Danger * Move danger up * Remove slather for now * Have danger failures in log * Add print out of API token for debugging * Make verbose * Make verbose for real * Try this * Revert "Try this" This reverts commit 3bfc163. * Try another thing * Get rid of logging
- Loading branch information
1 parent
a9be79c
commit 86d13e4
Showing
3 changed files
with
20 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
# Sometimes it's a README fix, or something like that - which isn't relevant for | ||
# including in a project's CHANGELOG for example | ||
declared_trivial = github.pr_title.include? "#trivial" | ||
has_source_changes = !git.modified_files.grep(/Source/).empty? | ||
|
||
# Make it more obvious that a PR is a work in progress and shouldn't be merged yet | ||
warn("PR is classed as Work in Progress") if github.pr_title.include? "[WIP]" | ||
|
||
# Warn when there is a big PR | ||
warn("This is a big PR, please consider splitting it up to ease code review.") if git.lines_of_code > 500 | ||
|
||
# Changelog entries are required for changes to source files. | ||
no_changelog_entry = !git.modified_files.include?("CHANGELOG.md") | ||
if has_source_changes && no_changelog_entry && not_declared_trivial | ||
fail("Any source code changes should have an entry in CHANGELOG.md.") | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
source 'https://rubygems.org' | ||
|
||
gem 'slather' | ||
gem 'danger' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters