Skip to content

Refactor NewWindow by using struct #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2015
Merged

Refactor NewWindow by using struct #55

merged 3 commits into from
May 22, 2015

Conversation

odknt
Copy link
Contributor

@odknt odknt commented May 18, 2015

@miketheprogrammer
Copy link
Owner

I love it, however I have to leave it as a pull request until I have time to change the examples.
Unless you would like to refactor the examples as well.

I will hopefully be resuming work on this for now. Until then, or until you refactor the examples, I hope people whom need this functionality will see this pull request and pull your fork.

Thanks for the work.

@odknt
Copy link
Contributor Author

odknt commented May 22, 2015

@miketheprogrammer Thanks for checking.

I changed examples and tutorials.
Adding to the above, I changed has_frame to conform specification below.

https://github.com/breach/thrust/blob/master/docs/api/window.md

  • has_frame creates a frameless window if true

@miketheprogrammer
Copy link
Owner

Merging. Thanks.

miketheprogrammer added a commit that referenced this pull request May 22, 2015
Refactor `NewWindow` by using struct
@miketheprogrammer miketheprogrammer merged commit a9a9ad5 into miketheprogrammer:master May 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants