Add checkUrl before NewWindow #47
Conversation
Signed-off-by: Francis Bouvier <francis.bouvier@xerus-technologies.fr>
|
Hi @miketheprogrammer , A small PR in order to perform a quick check on the url parameter of the NewWindow function. If the url scheme is empty this helper try to load the file from current directory. thrust.NewWindow("index.html", nil)If there is an error nothing happens as I don't know how you want to handle errors: panic or return error to the developer and let him handle it. |
| if u.Scheme == "" { | ||
| p, err := filepath.Abs(s) | ||
| if err != nil { | ||
| return p, err |
There was a problem hiding this comment.
Here you return the result of the failing call, but a few lines up you return the argument to the failing call. Why the difference?
|
You're right, it makes more sense to return the argument of the failing call. |
Add checkUrl before NewWindow
|
@miketheprogrammer Unfortunately I have too few experience in C or C++ to help with Thrust core, but I will be happy to be part of the discussion regarding the direction of the project. |
Signed-off-by: Francis Bouvier francis.bouvier@xerus-technologies.fr