-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds back SSR #126
Adds back SSR #126
Conversation
Still have to step through all the new SSR steps but my first impressions are:
|
Cool, I'll try my best to sub in Re Another thing the PR needs is an algo to slim down the size of the generated HTML. It's currently bloated with too many deku-related attributes, and it's possible to traverse the DOM & eliminate all of the atts that won't be used during hydration. That'll also make hydration much faster, as we'll be able to use the |
Now that you mention them, could you add an explanation of isBoring and isLucky? I'm assuming that "isBoring"~ pure and "isLucky" ~ unnested dyn element? |
So Lastly, SSR needs |
I'm going over |
Nvm, I understand now. The I can definitely recreate this logic using ancestry. |
@jterbraak |
The optimizer is now added. The best way to see the result is the tests. Now, every test in |
Added a client routing example as well: https://github.com/mikesol/vike-deku-client-routing. |
Migrated the docs to ssr to test it out (will migrate back if this isn't merged). They deploy fine on vercel. https://deku-documentation.vercel.app . The generated html via view-source is pretty complete, it picks up on almost 100% of the pages & healthy chunks are ignorable, so the rendering is faster than the previous docs 🚀 |
Merging so this doesn't go stale as I won't have time in the next few days. Thoroughly tested & deku docs are deployed with it 🚀 |
No description provided.