Better i915-perf / tracepoint tracking #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now we rely on the hw_id value from the data generated by the GPU to match the i915_request_add tracepoint hw_id. But starting with Gfx12 products, i915 started to delay hw_id picking until the i915_request_in tracepoint. This adds a 2 hops search to build the connection from i915-perf to i915_request_in to finally i915_request_add to find out the process that submitted the workload. Also don't look too far back (1 second right now).
Make it easier to see where is the process that scheduled this work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some recent (probably a couple of years :() changes in i915 have made the tracking of GPU generated data to tracepoint a bit different.
Here are a couple of commits to resolve that issue without breaking the correlation on older kernels.