Fixups for the ETL parser #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that visual studio and other editors will switch to 4 space tabs automatically.
Previously I interpreted incorrectly the meaning of the QueuePacket event. The mapping that we actually want is: * QueuePacket/Info -> Received by SW scheduler * DmaPacket/Start -> Moved to the HW queue * DmaPacket/Info -> Finished processing by gpu ISR Verified by comparing against gpuview output.
|
Thanks Andres! |
|
Thank you for reviewing. I still need to figure out how to properly distinguish between different engines... That info doesn't seem to be anywhere I look. But I'm probably looking in the wrong places. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output should now correctly match the gpuview output