Skip to content

Commit

Permalink
Remove code incorrectly flagging msm events
Browse files Browse the repository at this point in the history
All msm events that started with `msm_gpu_submit` where incorrectly
being flagged as `TRACE_FLAG_SW_QUEUE`.

Remove this code since events are tagged anyway elsewhere.

This fixes the graph tooltip incorrectly reporting SW queue duration
three times.
  • Loading branch information
pac85 authored and mikesart committed Nov 12, 2024
1 parent 43bf2c4 commit 330bb87
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/trace-cmd/trace-read.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1677,8 +1677,6 @@ static void init_event_flags( trace_data_t &trace_data, trace_event_t &event )
event.flags |= TRACE_FLAG_FENCE_SIGNALED;
else if ( strstr( event.name, "amdgpu_cs_ioctl" ) )
event.flags |= TRACE_FLAG_SW_QUEUE;
else if ( strstr( event.name, "msm_gpu_submit" ) )
event.flags |= TRACE_FLAG_SW_QUEUE;
else if ( strstr( event.name, "amdgpu_sched_run_job" ) )
event.flags |= TRACE_FLAG_HW_QUEUE;
}
Expand Down

0 comments on commit 330bb87

Please sign in to comment.