-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sierra indigo issue73 #74
Conversation
Wow, thanks for sorting this all out. The Also, the travis jobs are now all failing due to the long build time associated with the qt4 tap. I wonder if there's a way we can bottle that to avoid the long wait? |
install
Outdated
if [[ `sw_vers -productVersion` > "10.11" ]] | ||
then | ||
brew install cartr/qt4/qt | ||
SKIP_KEYS="--skip-keys=pyqt" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My preference would be to handle this via a rosdep override, if possible.
@wjwwood Is rosdep able to tell apart different versions of OS X the way it can different versions of Ubuntu?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing you mean putting the brew in a rosdep.
I think I still need the SKIP_KEYS.
Would you want to switch the rosdep override based on osx version here in the script?
I totally agree on the creepy factor. I found it by grepping through the cmake modules. I don't know much more than the doc page. As far as bottling qt4, I'm pretty much a brew noob and ruby rookie. I can give it a shot, but it might take a while. |
Based on the Travis build, it looks like El Cap is also using the forked qt4 formula— wasn't the intention that only Sierra would use it, and that the others could stick with upstream (desirable in part because then it's upstream taking care of bottling). |
I'll work on the conditional. Hopefully that is the problem. |
There's a Travis image for xcode 8.2— that might be a Sierra image, if you want to add it to the travis config and get some coverage of this new logic: https://docs.travis-ci.com/user/osx-ci-environment/#Xcode-version Looks like xcode 7 should also be moved to xcode 7.3.1. |
I've got two of the travis tests to pass. The 7.3 failure looks like a time-out because the sw_vers string being returned is not 10.10.x but 10.11.6. There is no bottle in osrf/simulation/simbody for El Capitan or Sierra.
The 8.2 full_desktop build fails for some strange conflict over f2py while installing numpy. I saw this on my El Capitan machine at work and had to manually delete the file. No idea how it got there. |
Not sure why this is sitting around in here.
Thanks for all the hard work here, however via #84 we now have a setup that works with QT5, so this is unnecessary. |
Yeah, I see a bunch of stuff moving again.
Sadly for my Baxter I need to get indigo working again.
…On Fri, Oct 20, 2017 at 3:13 PM, Mike Purvis ***@***.***> wrote:
Thanks for all the hard work here, however via #84
<#84> we now have a
setup that works with QT5, so this is unnecessary.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#74 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AF103JxJOzyxTIAaV-6YUk_EjQRKkerqks5suPD1gaJpZM4LDMFL>
.
|
What is it you need specifically from Indigo? Can you not just build Baxter's indigo packages from source against the Kinetic/Lunar base? |
I had all of the Rethink SDK working last November.
I really had not considered moving the SDK to lunar.
I figured it would be too hard.
Getting ROS to build on OSX has caused me to redefine "too hard."
I may give that a try first.
Now I have to get past the highSierra matplotlib issue.
…On Fri, Oct 20, 2017 at 9:07 PM, Mike Purvis ***@***.***> wrote:
What is it you need specifically from Indigo? Can you not just build
Baxter's indigo packages from source against the Kinetic/Lunar base?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#74 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AF103CQXYzuhCJwZS4Ho6pb8EnuF572Mks5suUPJgaJpZM4LDMFL>
.
|
@lloydc99 matplotlib issue in high sierra is already solved here https://github.com/Homebrew/homebrew-science/pull/6382 |
Include private version of qt4 for Sierra since it is not provided by main brew.
Patch bug in include headers in ros_console until fix is moved back to indigo.
Add a link to nosetests because it does not seem to be in the brew path.
Change the default search order for headers to look for OSX Frameworks last to get around issue #73.