Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

122 WIP upgrade some minor packages. #124

Merged
merged 3 commits into from
Apr 15, 2018
Merged

122 WIP upgrade some minor packages. #124

merged 3 commits into from
Apr 15, 2018

Conversation

mikelax
Copy link
Owner

@mikelax mikelax commented Apr 12, 2018

sadface trying to upgrade apollo and graphql (tag). left comment in #122 with error, will have to try other lib combinations.
Addresses #122

@mikelax mikelax self-assigned this Apr 12, 2018
@mikelax mikelax requested a review from nazar April 12, 2018 02:58
@mikelax
Copy link
Owner Author

mikelax commented Apr 14, 2018

@nazar I got all the apollo and react libs upgraded.
So there is an open ticket where graphql-tag does not work with graphql > 0.13.0

Also, I was able to just use the apollo-boost lib instead of bringing in all the libs separately. There are some peer warnings, its like a spiders web trying to get all the various lib versions to work together.

I think this is ready to go. Then I'll do a separate PR to upgrade the cra libs, and then one for the remaining dev deps like eslint, etc.

@mikelax
Copy link
Owner Author

mikelax commented Apr 14, 2018

@nazar ok I got the eslint upgrades done, and fixed a few errors in api.
If you want a facepalm, here is the reason the jsx-a11y lib isn't updated in the client folder.
TLDR, cra has issues using esllint, even after ejecting.... 😕
facebook/create-react-app#3418
odota/web#1020 (comment)
https://github.com/evcohen/eslint-plugin-jsx-a11y/issues/397#issuecomment-362839806

This is ready to be merged though. 👍

Copy link
Collaborator

@nazar nazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: 👍 💯

@mikelax mikelax merged commit 78a7e1d into master Apr 15, 2018
@mikelax mikelax deleted the 122-libupgrades branch April 15, 2018 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants