Parse unicode chars in local and domain parts of addresses #910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjg
force-pushed
the
encoded_raw_local_and_domain
branch
from
abad0fc to
1e5bbb5
Compare
kjg
force-pushed
the
encoded_raw_local_and_domain
branch
from
1e5bbb5 to
79805a7
Compare
kjg
force-pushed
the
encoded_raw_local_and_domain
branch
from
79805a7 to
a388cc9
Compare
|
@jeremy would you mind taking a quick looks at this one? I'm currently running into this problem in my app. Thanks! Sorry for all the PRs lately. I'd be happy to do whatever needed to become an official collaborator so I can help out and not bother you all so often. Is that something you'd be open to? |
|
Nice one. Thanks @kjg! PRs are the perfect route—please do keep them coming 😁 |
jeremy
added a commit
that referenced
this pull request
Sep 30, 2015
Parse unicode chars in local and domain parts of addresses
This was referenced Sep 30, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://en.wikipedia.org/wiki/Email_address: RFC 6531 and RFC 6532 allow for unicode characters in the local part and domain part of the email address. I received one of these emails today. This PR will allow the b_value_encoded email local and domain to be parsed.