Add Logger delivery method

[zacholauson]

Tested against: 1.8.7, 1.9.3, 2.1.5, and 2.2.0

Here is how it looks when an email gets delivered:

[carsonreinke]

@zacholauson Cool, but maybe this should use Logger instead and option to pass in.

[zacholauson]

Good point @carsonreinke, not sure why I didn't think of using Logger. I'll update this later today.

[bf4]

I don't think this is a feature in the gem that I'd want to maintain. @jeremy @mikel ?

[zacholauson]

@bf4 could you elaborate as to what you think would be difficult to maintain? Is there something you'd like to see changed in the code?

[zacholauson]

Fixed merge conflicts.

[bf4]

@jeremy @mikel @grosser @jeremyevans thoughts on having a STDOUT delivery method baked in, and the implementation?

[jeremyevans]

I think a STDOUT or a logger delivery method is fine, but the current name is misleading. This is currently a Logger delivery method, which just happens to have a default logger which logs to STDOUT.

I think this facility should it should probably be renamed (delivery_method = :logger), or the implementation be changed to something like $stdout.puts mail.encoded. Of the two, I prefer the former, as it is more flexible.

In terms of the implementation, this creates an unused Logger instances if the user passes in their own logger. It would be best to try to avoid that.

[grosser]

looks more like 'change global state so that this test passes', whatever test unsets them should clean them up

[zacholauson]

Hmm, this is from every other delivery method spec except for Mail::SendMail. While it doesn't seem to be required to be in the logger spec file, if I remove it from all delivery method specs, I get intermittent failures. I'll have to look more into why this exists.

[grosser]

In rails I am used to seeing the email in the logs during development, but I assume that's rails doing stuff and not mail itself ... 👍

[zacholauson]

I think a STDOUT or a logger delivery method is fine, but the current name is misleading. This is currently a Logger delivery method, which just happens to have a default logger which logs to STDOUT.

I think this facility should it should probably be renamed (delivery_method = :logger), or the implementation be changed to something like $stdout.puts mail.encoded. Of the two, I prefer the former, as it is more flexible.

I agree @jeremyevans, I'll update this to be Logger.

In terms of the implementation, this creates an unused Logger instances if the user passes in their own logger. It would be best to try to avoid that.

I didn't even think about that, thanks for catching that, I'll fix it.

[zacholauson]

Fixed merge conflicts.

[zacholauson]

Fixed merge conflicts.

[zacholauson]

Fixed merge conflicts.

[jeremy]

Thanks @zacholauson!!