Allow overriding default Net::POP3 read_timeout value #1117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Net::POP3 uses a default
read_timeout
of 60 seconds which can be overridden using read_timeout= method. On an application I work we deal with mailboxes having a large volume of emails and large attachments. Sometimes, depending on the traffic we may get aNet::ReadTimeout
error when hitting the 60 seconds limit.This PR allows specifying the
read_timeout
configuration for Net::POP3 by passing in the:read_timeout
configuration when specifying the retriever.Regarding the spec, I used
send
to invoke a private method. I saw it being used for some other specs so I figured it could be fine. Is there a better way to test this or it's already good?Thank you,
Fabio