Use the unicode replacement character #1002
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice @kjg. Thanks for revisiting! |
kjg
force-pushed
the
unicode_replacement_char
branch
from
7284935 to
0a7f1ae
Compare
|
@jeremy Can we include this in v2.7? |
kjg
force-pushed
the
unicode_replacement_char
branch
from
0a7f1ae to
4ac2141
Compare
instead of an empty string so that it is clear that there was some sort of encoding issue as opposed silently dropping data This is only easily accomplished on ruby 1.9 and above, so ruby 1.8.x will keep the empty string behavior.
kjg
force-pushed
the
unicode_replacement_char
branch
from
4ac2141 to
d958497
Compare
|
@jeremy is there anything I can do to help get this merged in? Does this just need to wait for a 2.7 branch to be cut off of master? If you're 👍 on this, please let me know what else I can do to help! Thanks! |
|
Merged @ 8e15ff5 ❤️ |
jeremy
reviewed
Jan 27, 2017
| decoded.valid_encoding? ? decoded : decoded.encode(Encoding::UTF_16LE, :invalid => :replace, :replace => "").encode(Encoding::UTF_8) | ||
| rescue Encoding::UndefinedConversionError, ArgumentError, Encoding::ConverterNotFoundError | ||
| warn "Encoding conversion failed #{$!}" | ||
| str.dup.force_encoding(Encoding::UTF_8) |
There was a problem hiding this comment.
Note this rescue clause also caught exceptions in e.g. Ruby19.decode_base64 and charset_encoder.encode up above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of an empty string so that it is clear that there was some sort of
encoding issue as opposed silently dropping data
(as discussed in #978)