add class for arrows when reached edge #41
Conversation
| edge = 'right' | ||
| } | ||
|
|
||
| stc.handleArrowsClassNames(edge); |
There was a problem hiding this comment.
@mikejacobson yeah I've fckd diff with formatting, but here is main diff here
| stc = evh.stc; | ||
|
|
||
| stc.scrollMovement.incrementScrollLeft(); | ||
| stc.scrollMovement.incrementScrollLeft() |
There was a problem hiding this comment.
Can you restore the ending semicolon here.
scrolling-tabs.js
Outdated
| return; | ||
| } | ||
|
|
||
| console.log(parseInt(stc.scrollingTabsActiveOffset || 0, 10)); |
There was a problem hiding this comment.
Can you remove this console.log.
|
|
||
| smv.slideMovableContainerToLeftPos(); | ||
| } else { | ||
| stc.handleArrowsClassNames('left'); |
There was a problem hiding this comment.
Can you add a condition so this function is only called if scrollingTabsActiveOffset is set, so it doesn't affect other users.
| stc.$movableContainer.stop().animate({ left: smv.getMovableContainerCssLeftVal() }, 'fast'); | ||
| } | ||
|
|
||
| var edge; |
There was a problem hiding this comment.
Basically the same comment as above: can you add a condition so this block of code (from here down to the call to handleArrowsClassNames on line 645) only executes if scrollingTabsActiveOffset is set, so other users aren't affected.
| stc.eventHandlers = new EventHandlers(stc); | ||
| stc.elementsHandler = new ElementsHandler(stc); | ||
|
|
||
| stc.scrollingTabsActiveOffset = opts.scrollingTabsActiveOffset || 0 |
There was a problem hiding this comment.
Can you add an ending semicolon here.
| if (!actionsTaken.didScrollToActiveTab) { | ||
| scrollMovement.scrollToActiveTab({ | ||
| isOnTabsRefresh: options.isWatchingTabs | ||
| isOnTabsRefresh: options.isWatchingTabs, |
There was a problem hiding this comment.
Can you remove the trailing comma here.
|
Other than the things I commented on, this looks good. If you can take care of those things, I can merge this in. Thanks for contributing! |
2 participants
I needed custom styling for arrows when scrolling tabs reached edge so I made this changes.