Building iOS to a real device fails

[raghav-mylagary]

When building the rnfbdemo project to real iOS device it fails with the below error

Link folly
ld: -U and -bitcode_bundle (Xcode setting ENABLE_BITCODE=YES) cannot be used together
clang: error: linker command failed with exit code 1 (use -v to see invocation)

[raghav-mylagary]

Probably related to this line https://github.com/mikehardy/rnfbdemo/blob/main/patches/react-native%2B0.69.0.patch#L101

[mikehardy]

Oh no! @raghavyadavm can you test that patch on any other project to see how it affects thing? If that patch is bad that means we have a generic problem with the upcoming react-native 0.69.1 as that patch will be included in the main release. This could be a big deal

[raghav-mylagary]

@mikehardy I created a new project using 69.1 and got the same error on a real device

1. npx react-native init RN --version=0.69.1
2. Enabled Hermes and use_frameworks in podfile
3. Build on a real iOS device

Error

[mikehardy]

Thanks again for bringing this up - I tagged you in the related react-native discussions for well-earned credit, of course unsubscribe if it's bothersome (and, apologies) - I dropped that part of the patch and make sure hermes is not enabled in make-demo.sh now, so it works with react-native 0.69.0 - I'll have to reverse that part of the patch as a forward-port to react-native 0.69.1, I'll do that in a bit

[mikehardy]

Turns out (from the related PR on react-native) that this may always be incompatible with bitcode but apparently bitcode is deprecated in Xcode 14 anyway. So, it is perhaps best to simply disable it, then there's no problem. In Podfile in postinstall this will do it, I will probably update make-demo.sh to do this when I get a chance

  installer.pods_project.targets.each do |target|
    target.build_configurations.each do |config|
      config.build_settings['ENABLE_BITCODE'] = 'NO'
    end
  end

[raghav-mylagary]

Great thanks for the workaround. I will update my project with these settings

[raghav-mylagary]

Disabling Bitcode started giving me errors with other libraries like Reanimated. I ended up using framework with the option use_frameworks! :linkage => :static and it solved the problem

[mikehardy]

Yes - other libraries may have issues as well, it really is a big change, thanks for reporting what worked, that will help me and others going forward!

[raghav-mylagary]

I create a PR to update the demo.sh with the above changes #11

[raghav-mylagary]

Unfortunately, the release builds are failing with these errors. I had to disable the Hermes for use_frameworks to work

[ptreitler]

Turns out (from the related PR on react-native) that this may always be incompatible with bitcode but apparently bitcode is deprecated in Xcode 14 anyway. So, it is perhaps best to simply disable it, then there's no problem. In Podfile in postinstall this will do it, I will probably update make-demo.sh to do this when I get a chance

  installer.pods_project.targets.each do |target|
    target.build_configurations.each do |config|
      config.build_settings['ENABLE_BITCODE'] = 'NO'
    end
  end

This workaround solved the issue for me, but I also had to disable Bitcode for release builds in my project's XCode config.