SwiftPM6: Fix to skip locking package build directory#38
Merged
mikeger merged 2 commits intomikeger:mainfrom Nov 26, 2024
Merged
Conversation
mikeger
reviewed
Nov 20, 2024
mikeger
approved these changes
Nov 26, 2024
Owner
|
@fxwx23 included in the release https://github.com/mikeger/XcodeSelectiveTesting/releases/tag/0.10.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with SwiftPM 6, a mechanism was introduced to lock the package build directory to prevent simultaneous builds/tests. Unfortunately, this behavior affects the
swift package dump-packagecommand used by this tool to retrieve dependency information. Specifically, when this tool is executed via a plugin in Swift 6, the workspace gets locked. This can lead to issues such as processes hanging and timing out when running on CI.Steps to reproduce
Running process never terminates with Swift 6.
Changes in this PR
To preserve the previous behavior, a new
--ignore-lockoption has been introduced. This patch ensures that the option is automatically added when running on Swift 6 or later.References