Skip to content

remove redundant keep_last() #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikeferguson merged 1 commit into from
Aug 11, 2024
Merged

remove redundant keep_last() #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion robot_calibration/src/finders/led_finder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ bool LedFinder::init(const std::string& name,
topic_name = node->declare_parameter<std::string>(name + ".topic", name + "/points");
subscriber_ = node->create_subscription<sensor_msgs::msg::PointCloud2>(
topic_name,
rclcpp::QoS(1).best_effort().keep_last(1),
rclcpp::QoS(1).best_effort(),
std::bind(&LedFinder::cameraCallback, this, std::placeholders::_1));

// Publish where LEDs were seen
Expand Down
2 changes: 1 addition & 1 deletion robot_calibration/src/finders/plane_finder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ bool PlaneFinder::init(const std::string& name,
node->declare_parameter<std::string>(name + ".topic", name + "/points");
subscriber_ = node->create_subscription<sensor_msgs::msg::PointCloud2>(
topic_name,
rclcpp::QoS(1).best_effort().keep_last(1),
rclcpp::QoS(1).best_effort(),
std::bind(&PlaneFinder::cameraCallback, this, std::placeholders::_1));

// Name of the sensor model that will be used during optimization
Expand Down
2 changes: 1 addition & 1 deletion robot_calibration/src/finders/scan_finder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ bool ScanFinder::init(const std::string& name,
topic_name = node->declare_parameter<std::string>(name + ".topic", name + "/scan");
subscriber_ = node->create_subscription<sensor_msgs::msg::LaserScan>(
topic_name,
rclcpp::QoS(1).best_effort().keep_last(1),
rclcpp::QoS(1).best_effort(),
std::bind(&ScanFinder::scanCallback, this, std::placeholders::_1));

// Name of the sensor model that will be used during optimization
Expand Down