Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Readme with Examples #124

Closed
wants to merge 1 commit into from
Closed

Updated Readme with Examples #124

wants to merge 1 commit into from

Conversation

Burgi0101
Copy link

@Burgi0101 Burgi0101 commented Feb 9, 2017

Added examples for Terminal & NPM Script usage including Windows support!
@mikeal Please check it and tell me if there is anything that I should change!

Added examples for Terminal & NPM Script usage including Windows support!

"scripts": {
"watch:osx": "watch 'npm run test -s' source"
"watch:windows": "watch "npm run test -s" source",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, escaping looks like it was missed here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think escaped quotationmarks are just not shown excaped on github!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps they got removed on commit somehow? Do you see them locally?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to check this, I am currently on my phone! Will try to commit again with escaped double quotes and then we'll see whats the issue!
Thx for pointing this out!

Copy link
Collaborator

@levithomason levithomason Mar 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, my first comment was on my phone and I also hesitated at first :P

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it's just not shown in the GUI here!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, I cannot pull the branch as GitHub doesn't know where the repo is:

image

But, if I down the raw file, I get this:

image

I've never seen the unknown repo thing before, but, perhaps it is related. What is clear is that the changes in this PR do not include escaped quotes.

@levithomason
Copy link
Collaborator

Just merged this in #135.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants