fix(watchTree): convert options.interval to seconds

[levithomason]

Fixes #112. interval was only converted to seconds through the CLI. There should be some higher order parseOptions added to handle this kind of thing.

This at least fixes the issue for the time being.

@mikeal review?

[nealstewart]

Please fix this! 👍

[levithomason]

Released as watch@0.19.3

[nealstewart]

Should you bounce to a major version number? Since this is a breaking API change :)

[mikeal]

+1 for moving to 1.0 anyway, this package is almost as old as npm :)

[levithomason]

Author wins, shipping 1.0

[levithomason]

Shipped 1.0.0, trying to deprecate 0.19.3 but it seems to be hanging. Will let it sit for a bit:

› npm deprecate watch@0.19.3 "Install watch@1.0.0 instead"

[levithomason]

Done

[hilko]

I just upgraded and it stopped working for me, as in it doesn't re-run the command after changes are made. It does run the first time.

At first I thought that the issue was that I had previously set --interval=0.1, but when I changed it to --interval=1 it still doesn't work. Removing --interval altogether does solve the issue.

Am I doing something wrong here, or could this be a bug?

(other than that: love this package. I use it in pretty much every project these days)

[levithomason]

Confirmed, thanks. The CLI is multiplying the interval * 1000, but then passing that to watchTree where it is again multiplied by 1000. So, if you waited 1000 seconds, it would have noticed :/

Fix coming

[levithomason]

@hilko released a fix in watch@1.0.1, let me know

[jbunton-atlassian]

This is still not correct. If you watch multiple directories then the same options object is passed from CLI to watchTree multiple times. watchTree mutates the options.interval each time.

I've raised #126 to fix this.