-
Notifications
You must be signed in to change notification settings - Fork 0
Test 4 #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Test 4 #6
Changes from all commits
04a24f2
fd1b791
bef0d75
63c5a22
0f9c286
18d5021
39523b6
2c4f00a
afd0911
cbbba16
671087b
6f8b623
b76ad24
9511eb6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
ignoreFiles='''/tmp/''' |
Original file line number | Diff line number | Diff line change | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,23 @@ | ||||||||||||||
package com.mycompany.app; | ||||||||||||||
|
||||||||||||||
class Person { | ||||||||||||||
private String firstName; | ||||||||||||||
private String lastName; | ||||||||||||||
private String addr; | ||||||||||||||
|
||||||||||||||
public Person(final String firstName, final String lastName) { | ||||||||||||||
this.firstName = firstName; | ||||||||||||||
this.lastName = lastName; | ||||||||||||||
} | ||||||||||||||
|
||||||||||||||
/** | ||||||||||||||
* @return the firstName | ||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. MissingSummary: A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
Suggested change
ℹ️ Learn about @sonatype-lift commandsYou can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
Note: When talking to LiftBot, you need to refresh the page to see its response. Was this a good recommendation? |
||||||||||||||
*/ | ||||||||||||||
public String getFirstName() { | ||||||||||||||
return firstName; | ||||||||||||||
} | ||||||||||||||
|
||||||||||||||
public String getLastName() { | ||||||||||||||
return lastName; | ||||||||||||||
} | ||||||||||||||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,6 +9,8 @@ | |
|
||
public class CBOClassParsingTest { | ||
|
||
private String unused; | ||
|
||
private Locale defaultLocale; | ||
|
||
@BeforeEach | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
package com.mycompany.app; | ||
|
||
public class PersonTest { | ||
public void testPerson() { | ||
final String notUsed = "foo-bar"; | ||
} | ||
|
||
private String getExpectedValue() { | ||
return "I am not used"; | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
package org.hjug.metrics; | ||
|
||
import static org.junit.jupiter.api.Assertions.assertEquals; | ||
|
||
import java.util.Locale; | ||
import org.junit.jupiter.api.AfterEach; | ||
import org.junit.jupiter.api.BeforeEach; | ||
import org.junit.jupiter.api.Test; | ||
|
||
public class DupeTest { | ||
|
||
private String unused; | ||
|
||
private Locale defaultLocale; | ||
|
||
@BeforeEach | ||
public void before() { | ||
defaultLocale = Locale.getDefault(Locale.Category.FORMAT); | ||
Locale.setDefault(Locale.Category.FORMAT, Locale.ENGLISH); | ||
} | ||
|
||
@AfterEach | ||
public void after() { | ||
Locale.setDefault(defaultLocale); | ||
} | ||
|
||
@Test | ||
void test() { | ||
String result = "A value of 20 may denote a high amount of coupling within the class"; | ||
CBOClass cboClass = new CBOClass("a", "a.txt", "org.hjug", result); | ||
assertEquals(Integer.valueOf(20), cboClass.getCouplingCount()); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UnusedVariable: The field 'addr' is never read.
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
@sonatype-lift ignore
@sonatype-lift ignoreall
@sonatype-lift exclude <file|issue|path|tool>
file|issue|path|tool
from Lift findings by updating your config.toml fileNote: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]