Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log exceptions in dumped crash logs #742

Merged
merged 1 commit into from
May 2, 2024
Merged

Conversation

FooIbar
Copy link
Contributor

@FooIbar FooIbar commented May 2, 2024

So the user won't need to screenshot the crash screen.

@MajorTanya
Copy link
Member

The thing is, sometimes the exception does appear in the log file. When I first looked at this a while ago, I couldn't even reproduce the missing exception from the logs, even with a release build compile.

@FooIbar
Copy link
Contributor Author

FooIbar commented May 2, 2024

The thing is, sometimes the exception does appear in the log file. When I first looked at this a while ago, I couldn't even reproduce the missing exception from the logs, even with a release build compile.

It's just a few bytes more even if it's duplicate, I think we can afford that.

@MajorTanya
Copy link
Member

The thing is, sometimes the exception does appear in the log file. When I first looked at this a while ago, I couldn't even reproduce the missing exception from the logs, even with a release build compile.

It's just a few bytes more even if it's duplicate, I think we can afford that.

Oh, absolutely, I'd love to not have to ask people to give me the screenshot, only for them to have already restarted the app (or never respond in the first place).
Looking forward to this.

Would it be too much to put a "Latest Exception" header before it or something like that? To differentiate it from later ones

@FooIbar
Copy link
Contributor Author

FooIbar commented May 2, 2024

The thing is, sometimes the exception does appear in the log file. When I first looked at this a while ago, I couldn't even reproduce the missing exception from the logs, even with a release build compile.

It's just a few bytes more even if it's duplicate, I think we can afford that.

Oh, absolutely, I'd love to not have to ask people to give me the screenshot, only for them to have already restarted the app (or never respond in the first place). Looking forward to this.

Would it be too much to put a "Latest Exception" header before it or something like that? To differentiate it from later ones

The following log will have something like

--------- beginning of main

@AntsyLich AntsyLich merged commit a3d438e into mihonapp:main May 2, 2024
1 check passed
xteamlyer pushed a commit to xteamlyer/mihon that referenced this pull request May 2, 2024
xteamlyer pushed a commit to xteamlyer/mihon that referenced this pull request May 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2024
@FooIbar FooIbar deleted the log branch May 5, 2024 08:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants