Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action Refactoring - Migrating Actions to Use Node 20 #310

Merged
merged 6 commits into from
Feb 1, 2024
Merged

Action Refactoring - Migrating Actions to Use Node 20 #310

merged 6 commits into from
Feb 1, 2024

Conversation

pabalaba
Copy link
Contributor

Migration to updated actions

As stated in this post, GitHub Actions will transition from Node 16, which has reached its EOL, to Node 20.
A couple of actions still need to be updated to Node 20, but PRs have already been opened in the relevant repositories.

@AntsyLich
Copy link
Member

The arguments parameter of gradle/actions/setup-gradle has been deprecated. Can you address that?

@pabalaba
Copy link
Contributor Author

pabalaba commented Feb 1, 2024

Let me know if a different version of gradle is needed.

@AntsyLich
Copy link
Member

Well that failed. Just don't have a specific version I guess?

@pabalaba
Copy link
Contributor Author

pabalaba commented Feb 1, 2024

Removed the version. If needed can be set again as "current" which uses the stable version of gradle.

@AntsyLich
Copy link
Member

The Gradle wrapper's version (default, useful for matrix builds)

Default is fine

@AntsyLich AntsyLich merged commit 170daf9 into mihonapp:main Feb 1, 2024
1 check passed
@AntsyLich
Copy link
Member

Thanks for the PR

kaiserbh pushed a commit to kaiserbh/mihon that referenced this pull request Feb 18, 2024
* feat: updated build_pull_request actions version

* feat: updated build_push actions version

* feat: updated issue_moderator action version

* feat: updated deprecated arguments in build_pull_request

* feat: updated deprecated arguments in build_push

* feat: removed explicit declaration of gradle version

(cherry picked from commit 170daf9)

# Conflicts:
#	.github/workflows/build_pull_request.yml
#	.github/workflows/build_push.yml
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants