Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle multiple duplicates on add duplicate dialogue #1861

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

NarwhalHorns
Copy link
Contributor

Adds functionality to show and choose between all the duplicates found when adding a manga instead of just the first one found.

image

@AntsyLich
Copy link
Member

why not just have the entries be places similar to comfortable library display mode

@NarwhalHorns
Copy link
Contributor Author

NarwhalHorns commented Mar 17, 2025

why not just have the entries be places similar to comfortable library display mode

hmm, and just have the author/artists underneath it or something? not sure what you mean. I wanted to try to provide as much info to the user to differentiate dupes or not but there's not actually that much lmao so yeah ended up being kinda empty on the right side

how bout this?

image

@MajorTanya
Copy link
Member

What about this artist's impression?

Graphic design is my passion

@NarwhalHorns
Copy link
Contributor Author

What about this artist's impression?

Graphic design is my passion

don't need the title as they are the same but yeah i like putting the source at the bottom like that, will try it

@NarwhalHorns
Copy link
Contributor Author

update boop

image

@MajorTanya
Copy link
Member

If we go with that, make sure we have all the cards be the same height

@NarwhalHorns
Copy link
Contributor Author

If we go with that, make sure we have all the cards be the same height

how lol

@cuong-tran
Copy link
Contributor

If we go with that, make sure we have all the cards be the same height

how lol

truncate the title, shouldn't they have same title which already known to user?

@NarwhalHorns
Copy link
Contributor Author

If we go with that, make sure we have all the cards be the same height

how lol

truncate the title, shouldn't they have same title which already known to user?

they don't have a title?

@MajorTanya
Copy link
Member

If we go with that, make sure we have all the cards be the same height

how lol

truncate the title, shouldn't they have same title which already known to user?

The title isn't even in the card any more in the latest screenshot.

how lol

No idea. Maybe some min height constraint or something? I'm sure there's a thing for this somewhere in Compose.

@NarwhalHorns
Copy link
Contributor Author

No idea. Maybe some min height constraint or something? I'm sure there's a thing for this somewhere in Compose.

hmm, it's complicated cus they have no set height, somehow need to make them all as tall as the tallest one

@MajorTanya
Copy link
Member

No idea. Maybe some min height constraint or something? I'm sure there's a thing for this somewhere in Compose.

hmm, it's complicated cus they have no set height, somehow need to make them all as tall as the tallest one

That seems fair, I'm sure that also exist as some sort of height constraint.

@NarwhalHorns
Copy link
Contributor Author

can't figure it out, how tied to having them the same height are we lmao

@NarwhalHorns
Copy link
Contributor Author

so got this but also this

nice oof
image image

not ideal but i think it's the best we can get

@MajorTanya
Copy link
Member

Looking at this makes me wanna see titles tbh. Especially when you have some sources that may have "Official" or "Coloured" or whatever other title addendums.

@NarwhalHorns
Copy link
Contributor Author

Looking at this makes me wanna see titles tbh. Especially when you have some sources that may have "Official" or "Coloured" or whatever other title addendums.

well, currently they wouldn't be caught. we only find duplicates by an exact match. BUT, if we are thinking about mkaing the query a more robust search then having the titles would make sense. so i guess we cna put the titles in for now and they would be identical or add it if/when we get more complex search?

@MajorTanya
Copy link
Member

Looking at this makes me wanna see titles tbh. Especially when you have some sources that may have "Official" or "Coloured" or whatever other title addendums.

well, currently they wouldn't be caught. we only find duplicates by an exact match. BUT, if we are thinking about mkaing the query a more robust search then having the titles would make sense. so i guess we cna put the titles in for now and they would be identical or add it if/when we get more complex search?

Sounds sensible to me, yeah

And if/when we make the search more fuzzy, we could just throw a good old "LIKE" clause into the SQL (assuming that's what we use for the query)

@NarwhalHorns
Copy link
Contributor Author

And if/when we make the search more fuzzy, we could just throw a good old "LIKE" clause into the SQL (assuming that's what we use for the query)

Yeah I was thinking a few different things but that would be a good first step... might try doing that now and see how it comes out actually

@NarwhalHorns
Copy link
Contributor Author

LIKE fuzzy search

image

@MajorTanya
Copy link
Member

MajorTanya commented Mar 18, 2025

similar names

Anway yeah, this looks alright in the title department.

@NarwhalHorns
Copy link
Contributor Author

NarwhalHorns commented Mar 18, 2025

similar names

Anway yeah, this looks alright in the title department.

fuck.

tho this is a good point, fuzzy search will probably start getting a lot more false dupes? but kinda unavoidable if we want fuzzy I guess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants