Handle multiple duplicates on add duplicate dialogue #1861
Conversation
app/src/main/java/eu/kanade/presentation/manga/DuplicateMangaDialog.kt
Outdated
Show resolved
Hide resolved
…ialog.kt Co-authored-by: Cuong-Tran <cuongtran.tm@gmail.com>
app/src/main/java/eu/kanade/presentation/manga/DuplicateMangaDialog.kt
Outdated
Show resolved
Hide resolved
|
why not just have the entries be places similar to comfortable library display mode |
hmm, and just have the author/artists underneath it or something? not sure what you mean. I wanted to try to provide as much info to the user to differentiate dupes or not but there's not actually that much lmao so yeah ended up being kinda empty on the right side how bout this?
|
|
What about this artist's impression?
|
don't need the title as they are the same but yeah i like putting the source at the bottom like that, will try it |
|
update boop
|
|
If we go with that, make sure we have all the cards be the same height |
how lol |
truncate the title, shouldn't they have same title which already known to user? |
they don't have a title? |
The title isn't even in the card any more in the latest screenshot.
No idea. Maybe some min height constraint or something? I'm sure there's a thing for this somewhere in Compose. |
hmm, it's complicated cus they have no set height, somehow need to make them all as tall as the tallest one |
That seems fair, I'm sure that also exist as some sort of height constraint. |
|
can't figure it out, how tied to having them the same height are we lmao |
|
so got this but also this
not ideal but i think it's the best we can get |
|
Looking at this makes me wanna see titles tbh. Especially when you have some sources that may have "Official" or "Coloured" or whatever other title addendums. |
well, currently they wouldn't be caught. we only find duplicates by an exact match. BUT, if we are thinking about mkaing the query a more robust search then having the titles would make sense. so i guess we cna put the titles in for now and they would be identical or add it if/when we get more complex search? |
Sounds sensible to me, yeah And if/when we make the search more fuzzy, we could just throw a good old "LIKE" clause into the SQL (assuming that's what we use for the query) |
Yeah I was thinking a few different things but that would be a good first step... might try doing that now and see how it comes out actually |
|
LIKE fuzzy search
|
|
fuck. tho this is a good point, fuzzy search will probably start getting a lot more false dupes? but kinda unavoidable if we want fuzzy I guess |
Adds functionality to show and choose between all the duplicates found when adding a manga instead of just the first one found.