Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added editorconfig indent_style to ensure uniform auto-formating. #1720

Closed

Conversation

fatotak
Copy link

@fatotak fatotak commented Feb 13, 2025

.editorconfig is used by this project, and space indenting is also used.

However, the following were missing from .editorconfig:

  1. root: user .editorconfig settings higher in the directory hierarchy than the project root would get propagated to this project.
  2. indent_style: user .editorconfig settings or IDE settings that specify indent_style to tab would get propagated to this project.

This fix ensures tab/spaces is uniform across the project.
Autoformat has not been run across the entire project (results in hundreds of changes if done - mainly newlines and cleanup of unused imports which is not related to this change).

fatotak added a commit to fatotak/mihon that referenced this pull request Feb 13, 2025
fatotak added a commit to fatotak/mihon that referenced this pull request Feb 13, 2025
@AntsyLich
Copy link
Member

Superseded by #1731

@AntsyLich AntsyLich closed this Feb 15, 2025
@fatotak fatotak deleted the bugfix/editoconfig_missing_indent_style branch February 15, 2025 17:42
fatotak added a commit to fatotak/mihon that referenced this pull request Feb 17, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants