fix for LibreSSL 3.5 #663
Merged
fix for LibreSSL 3.5 #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LibreSSL has made HMAC_CTX and DH opaque so tweak the crypto to cope with it. Lifted from OpenBSD port patches.
vyzo
reviewed
Jan 15, 2022
| @@ -372,7 +372,7 @@ END-C | |||
| (c-declare #<<END-C | |||
| static HMAC_CTX *ffi_create_HMAC_CTX () | |||
| { | |||
| #if OPENSSL_VERSION_NUMBER < 0x10100000L || defined (LIBRESSL_VERSION_NUMBER) | |||
| #if OPENSSL_VERSION_NUMBER < 0x10100000L | |||
There was a problem hiding this comment.
can we keep this guard around for older versions of LibreSSL?
There was a problem hiding this comment.
I'm not an expert on using libressl but it seems to be incorrect check in any case:
"if using old OpenSSL or any LibreSSL version -> use old API"
Which versions should use the old API?
There was a problem hiding this comment.
well it used to not compile with early libressl versions that didnt have the new api.
I am fine removing these guards, just concerned about older openbsd installations.
There was a problem hiding this comment.
ok, lets merge and if it causes problems for people we can add a more specific (versioned) guard.
vyzo
approved these changes
Jan 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LibreSSL 3.5 has made HMAC_CTX and DH opaque so code using it should be switched to use accessor functions.
Lifted from OpenBSD port patches.