Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve issues with gambit head readtable changes #634

Merged
merged 4 commits into from
Oct 19, 2021
Merged

resolve issues with gambit head readtable changes #634

merged 4 commits into from
Oct 19, 2021

Conversation

vyzo
Copy link
Collaborator

@vyzo vyzo commented Oct 19, 2021

fixes #626

@vyzo
Copy link
Collaborator Author

vyzo commented Oct 19, 2021

grrr, still some issues -- script main functions are not getting invoked.

@vyzo vyzo marked this pull request as draft October 19, 2021 19:07
@vyzo vyzo marked this pull request as ready for review October 19, 2021 19:23
@vyzo
Copy link
Collaborator Author

vyzo commented Oct 19, 2021

alright, this is ready; we just need to make sure there is no regression with v4.9.3 release

Copy link
Collaborator

@fare fare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does it work on both 4.9.3 and latest gambit?

@vyzo
Copy link
Collaborator Author

vyzo commented Oct 19, 2021

yup, just tested (and fixed it) with v4.9.3 and waiting for another verification with head; will merge soon.

@vyzo vyzo merged commit bbfdffd into master Oct 19, 2021
@vyzo vyzo deleted the issue-626 branch October 19, 2021 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gambit changed readtable and renamed brace-keyword to brace-handler
2 participants