Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline with-list-builder, second version #539

Merged
merged 1 commit into from
Jun 5, 2020
Merged

Inline with-list-builder, second version #539

merged 1 commit into from
Jun 5, 2020

Conversation

fare
Copy link
Collaborator

@fare fare commented Jun 5, 2020

This version is about 10% faster on my machine.
See https://gist.github.com/vyzo/3db10df3a1fd886bbda5d57369455ff6

vyzo
vyzo reviewed Jun 5, 2020
View reviewed changes
vyzo
vyzo approved these changes Jun 5, 2020
View reviewed changes
Copy link
Collaborator

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

We can also change peek to use ##cdr instead of cdr, although it will probably not make much difference.
If an application uses it a lot though, it might make a dent from avoiding the type check.

@fare fare merged commit 48f45c1 into mighty-gerbils:master Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyzo vyzo vyzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fare @vyzo