Pretty print test compression map differences #853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't strictly needed as it only contains a small number of entries, but is consistent nonetheless.
Codecov Report
@@ Coverage Diff @@
## master #853 +/- ##
=========================================
+ Coverage 57.96% 58% +0.03%
=========================================
Files 42 42
Lines 10675 10675
=========================================
+ Hits 6188 6192 +4
+ Misses 3398 3395 -3
+ Partials 1089 1088 -1
Continue to review full report at Codecov.
|
tmthrgd
changed the title
|
/cc @pierresouchay (who wrote these test cases in #668). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I'm working on the compression code and I trip either of these tests I keep being hit with a massive wall of incomprehensible text that tells me nothing about what's gone wrong. These maps end up with nearly a thousand different entries.
This PR adds a helper function that formats the maps in a much nicer way and greatly simplifies debugging test failures.