Skip to content

Use NextLabel in compressionLenHelper #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tmthrgd
Copy link
Collaborator

@tmthrgd tmthrgd commented Nov 27, 2018

This avoids the allocation of Split and should have slightly better performance.

This was pulled out of #818 and is reflected in the benchmarks there.

This avoids the allocation of Split and should have slightly better
performance.
@tmthrgd tmthrgd requested a review from miekg November 27, 2018 07:31
@codecov-io
Copy link

codecov-io commented Nov 27, 2018

Codecov Report

Merging #826 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #826      +/-   ##
==========================================
+ Coverage   57.53%   57.57%   +0.03%     
==========================================
  Files          42       42              
  Lines       10825    10823       -2     
==========================================
+ Hits         6228     6231       +3     
+ Misses       3517     3513       -4     
+ Partials     1080     1079       -1
Impacted Files Coverage Δ
msg.go 78.31% <100%> (+0.57%) ⬆️
server.go 68.68% <0%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c9c9bf...b0597cc. Read the comment docs.

@tmthrgd
Copy link
Collaborator Author

tmthrgd commented Nov 27, 2018

Hold off on this for now. I'm working on replacing compressionLenHelper entirely and this will only cause difficulty merging.

@tmthrgd tmthrgd closed this Nov 27, 2018
@tmthrgd tmthrgd deleted the comp-len-nextlabel branch November 27, 2018 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants