Use map[string]struct{} for compression map in Len #820
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
map[string]int
requires 8 bytes per entry to store the unused position information.I couldn't get any clean benchmarks from this, butmap[string]struct{}
definitely uses less memory thanmap[string]int
.This does unfortunately make the related test cases slightly weaker as they no longer test that the
Len
code is finding compression points in the correct spot.Updates #709.
Edit: I was able to get some better benchmarks that show a very notable improvement in memory use.