Tests updates #556
Merged
Tests updates #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
1.8 breaks, 1.9 works - restarting a 1.8 job - if this is a 1.8 thing I'm inclined to drop that on the spot. |
Codecov Report
@@ Coverage Diff @@
## master #556 +/- ##
==========================================
- Coverage 58.3% 58.12% -0.19%
==========================================
Files 37 37
Lines 9877 9877
==========================================
- Hits 5759 5741 -18
- Misses 3085 3095 +10
- Partials 1033 1041 +8
Continue to review full report at Codecov.
|
Use :0 for loopback testing. This is more portable between testing environments. Add testRR that calls NewRR and throws error away - apply it everywhere where needed. It seems only Go 1.9 can deal with :0 being used. Disable 1.8 in travis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use :0 for loopback testing. This is more portable between testing environments.
Add testRR that calls NewRR and throws error away - apply it everywhere where needed.