Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose RR and RR Header Len #326

Closed
wants to merge 2 commits into from
Closed

Conversation

matje
Copy link
Contributor

@matje matje commented Feb 29, 2016

Related to issue #316

@miekg
Copy link
Owner

miekg commented Feb 29, 2016

I think it makes most sense to do this in the same way as we did Copy,

dns/msg.go

Line 1893 in 85b661b

// Copy returns a new RR which is a deep-copy of r.

This would be a minimal I think Len() would then automatically work for RR_Header as that is an RR as well.

Also: currently the tests don't compile

@andrewtj
Copy link
Collaborator

andrewtj commented Mar 5, 2016

Although not relevant to implementing this as func Len(RR) int, for future reference types_generate.go builds ztypes.go via go generate.

@miekg
Copy link
Owner

miekg commented Mar 10, 2016

@matje are you making this change? Or do you want to closer this PR and open a new one?

@matje
Copy link
Contributor Author

matje commented Mar 11, 2016

@miekg It's still on my todo list

@matje
Copy link
Contributor Author

matje commented Mar 17, 2016

Easier to close this PR and create a new one with the easier fix, see #333

@matje matje deleted the issue-316-rdlen branch March 17, 2016 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants