Remove fuzz from .github/workflows/go.yml #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Fuzz step is still failing even after #1237. See these two runs on the master branch: https://github.com/miekg/dns/runs/2031876704 & https://github.com/miekg/dns/runs/2031876289. They failed even though the run for the #1237 PR succeeded: https://github.com/miekg/dns/pull/1237/checks?check_run_id=2027941443.
The problem is caused by github.com/dvyukov/go-fuzz/go-fuzz (and it's dependencies as it lacks a go.mod file) not being included in our go.mod file. For some reason the go command seems to be non-deterministically picking a version of golang.org/x/tools to download, sometimes picking one that's too old. I'm not sure why that is, and it feels like a bug in the go command or go module proxy.
We can either add it to our go.mod and go.sum files or remove the step. I think removing it (this PR) is the best option as it doesn't actually run the fuzzer, it merely checks it builds. go1.17/go1.18 is set to have a native fuzzer support (see golang.org/issue/44551) so I don't think wrangling this makes a ton of sense.
Also oss-fuzz is actually running the fuzzers so they'd break loudly if we broke the fuzz targets anyway.
This should finally fix the failing CI runs.
Updates #1237