Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support parsing known RR types in RFC 3597 format #1211

Merged
merged 4 commits into from
Jan 30, 2021
Merged

Support parsing known RR types in RFC 3597 format #1211

merged 4 commits into from
Jan 30, 2021

Commits on Jan 30, 2021

  1. Support parsing known RR types in RFC 3597 format 

    This is the format used for "Unknown DNS Resource Records", but it's
also useful to support parsing known RR types in this way.

RFC 3597 says:

   An implementation MAY also choose to represent some RRs of known type
   using the above generic representations for the type, class and/or
   RDATA, which carries the benefit of making the resulting master file
   portable to servers where these types are unknown.  Using the generic
   representation for the RDATA of an RR of known type can also be
   useful in the case of an RR type where the text format varies
   depending on a version, protocol, or similar field (or several)
   embedded in the RDATA when such a field has a value for which no text
   format is known, e.g., a LOC RR [RFC1876] with a VERSION other than
   0.

   Even though an RR of known type represented in the \# format is
   effectively treated as an unknown type for the purpose of parsing the
   RDATA text representation, all further processing by the server MUST
   treat it as a known type and take into account any applicable type-
   specific rules regarding compression, canonicalization, etc.
    @tmthrgd
    tmthrgd committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    615e73f View commit details
    Browse the repository at this point in the history

  2. Correct mistakes in TestZoneParserAddressAAAA 

    This was spotted when writing TestParseKnownRRAsRFC3597.
    @tmthrgd
    tmthrgd committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    40b4195 View commit details
    Browse the repository at this point in the history

  3. Eliminate canParseAsRR 

    This has the advantage that concrete types will now be returned for
parsed ANY, NULL, OPT and TSIG records.
    @tmthrgd
    tmthrgd committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    26fa485 View commit details
    Browse the repository at this point in the history

  4. Expand TestDynamicUpdateParsing for RFC 3597 

    This ensures we're properly handling empty RDATA for RFC 3597 parsed
records.
    @tmthrgd
    tmthrgd committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    d7232ae View commit details
    Browse the repository at this point in the history