Skip to content

Conversation

@m2ux
Copy link
Contributor

@m2ux m2ux commented Jan 21, 2026

🎫 Issue

Addresses follow-up from PM-21404

Related: PR #497

Problem

PR #497 changed the MIDNIGHT_RESERVE_CONTRACTS_PATH to:

export MIDNIGHT_RESERVE_CONTRACTS_PATH="${GIT_ROOT}/midnight-reserve-contracts"

This expects developers to clone midnight-reserve-contracts inside the midnight-node directory, but:

  • Developers typically have repos as sibling directories in their workspace
  • The CI action already clones as a sibling (${GITHUB_WORKSPACE}/../midnight-reserve-contracts)
  • This creates a mismatch between local dev and CI environments

Solution

Change the path to reference the contracts repo as a sibling directory:

export MIDNIGHT_RESERVE_CONTRACTS_PATH="${GIT_ROOT}/../midnight-reserve-contracts"

Changes

File Change
local-environment/.envrc Update path from child to sibling directory

Testing

  • .envrc sources without error
  • Path resolves correctly to sibling directory
  • Matches CI behavior

Checklist

  • Changes are minimal and focused
  • Changelog added
  • Self-reviewed the diff

JIRA: PM-21404

@m2ux m2ux self-assigned this Jan 21, 2026
@github-actions
Copy link
Contributor

kics-logo

KICS version: v2.1.16

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 123
LOW LOW 12
INFO INFO 85
TRACE TRACE 0
TOTAL TOTAL 220
Metric Values
Files scanned placeholder 28
Files parsed placeholder 28
Files failed to scan placeholder 0
Total executed queries placeholder 73
Queries failed to execute placeholder 0
Execution time placeholder 6

Change MIDNIGHT_RESERVE_CONTRACTS_PATH from child directory to sibling
directory to match typical developer workspace layouts and CI behavior.

JIRA: PM-21404
@m2ux m2ux marked this pull request as ready for review January 21, 2026 10:53
@m2ux m2ux requested a review from a team as a code owner January 21, 2026 10:53
Copy link
Contributor

@gilescope gilescope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we pull it in as a submodule please?
That way we've got a link to the actual contracts that should be used. I think that would be very beneficial.

Copy link
Contributor

@gilescope gilescope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for now we do it like this till we've open sourced the contracts repo.

@gilescope gilescope enabled auto-merge (squash) January 21, 2026 16:23
@gilescope gilescope merged commit 1b7092e into main Jan 21, 2026
36 checks passed
@gilescope gilescope deleted the fix/reserve-contracts-sibling-path branch January 21, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants