Build improvements #65
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Mark Ide <546518+mide@users.noreply.github.com>
…ents See the last note here: https://github.com/koalaman/shellcheck/wiki/SC2086 > As always, this warning can be ignored on a case-by-case basis. > This is especially relevant when BASH may not be available for the array work around. For example, use in eval or in command options where script has total control of the variables...
We don't use any Ruby stuff (the default for historic reasons), so we explicitly disable it.
mide
reviewed
Apr 8, 2020
magneticflux-
force-pushed
the
build-improvements
branch
from
783c7a5 to
c46a74b
Compare
mide
reviewed
Jun 7, 2020
Owner
|
Shoot, there are merge conflicts between this branch and |
Merged
mide
added a commit
that referenced
this pull request
Jul 29, 2020
Closes #65, thanks @magneticflux-
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build and script improvements extracted from #54