Fix the invalid token bug for default github instances

[thesujai]

Linked Issue(s)

Regression caused by #646
Fixes #653

Proposed changes (including videos or screenshots)

Actually the problem the get_custom_github_domain was returning a default github domain when no custom domain existed. Then we were doing a domain check again in the GithubApiService. This resulted in the final api looking like api.github.com/api/v3.

Now the get_custom_github_domain implicitly return a None allowing for a comparision to happen in GithubApiService

Further comments

Summary by CodeRabbit

• Refactor
  • Updated handling of missing custom GitHub domains to return no value instead of a default domain.
  • Added clarification in comments regarding the intentional absence of a default domain.

[coderabbitai]

Walkthrough

The change modifies the get_custom_github_domain function in the GitHub utility module to return None instead of the default public GitHub API domain when no custom domain is configured for an organization. A clarifying comment was added to explain this intentional behavior.

Changes

File(s)	Change Summary
backend/analytics_server/mhq/utils/github.py	Removed the use of the default GitHub API domain in get_custom_github_domain; added clarifying comment.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant GitHubUtils

    Caller->>GitHubUtils: get_custom_github_domain(org_id)
    alt Custom domain exists
        GitHubUtils-->>Caller: return custom domain
    else No custom domain
        GitHubUtils-->>Caller: return None
    end

Loading

Assessment against linked issues

Objective	Addressed	Explanation
Prevent fallback to default domain if no custom GitHub domain is set (#653)	✅

Poem

A hop, a skip, a tweak in the code,
No more default paths for tokens to explode.
If no custom domain is found, we now return none,
The sync engine’s confusion is finally done!
🐇✨

Tip

⚡️ Faster reviews with caching

• CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8d4a3db and 97bbe1e.

📒 Files selected for processing (1)

• backend/analytics_server/mhq/utils/github.py (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: All file linting

🔇 Additional comments (1)

backend/analytics_server/mhq/utils/github.py (1)

72-74: Well-documented fix that addresses the root cause.

This change correctly modifies the function behavior to return None instead of a default domain when no custom domain is configured. The added comments clearly explain the rationale behind this change, making the code more maintainable for future developers.

The fix aligns with the PR objective to prevent incorrect API URL formation such as api.github.com/api/v3 by letting GithubApiService handle the default domain case properly.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.