Gitlab org_name migration #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… orgname when it changes
adnanhashmi09
force-pushed
the
gitlab-org-name-migration
branch
from
96086f1 to
3c9c95d
Compare
samad-yar-khan
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issue(s)
We ran into a problem where gitlab org_name was not being set properly for nested orgs and suborgs.
And the frontend was making queries using group_name instead of group idempotent key (internal Id given by gitlab)
This PR sets the org name properly for nested orgs and sends group_id back to frontend for querying using that id
Acceptance Criteria fulfillment
Proposed changes (including videos or screenshots)
Further comments