Skip to content

Update Incident Service ETL to use BookmarkService #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 8, 2024
Merged

Update Incident Service ETL to use BookmarkService #511

merged 2 commits into from
Aug 8, 2024

Conversation

samad-yar-khan
Copy link
Contributor

Linked Issue(s)

#500

Acceptance Criteria fulfillment

  • Update usage of BookmarkService throughout the codebase
    • Update Incident ETL to use bookmark service

Proposed changes (including videos or screenshots)

  • update IncidentsProviderETLHandler.process_service_incidents to use datetime object as timestamp.
  • update IncidentsETLHandler to use bookmark service.
  • Use datetime object as bookmark for incident syncs

Further comments

@samad-yar-khan samad-yar-khan merged commit 798c52c into main Aug 8, 2024
3 checks passed
@samad-yar-khan samad-yar-khan deleted the bookmark-service-usages branch August 8, 2024 14:38
@samad-yar-khan samad-yar-khan mentioned this pull request Aug 8, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayantbh jayantbh jayantbh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samad-yar-khan @jayantbh